Attach Agent ID to remote-write requests #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in data dir for flow.
tpaschalis
reviewed
Dec 19, 2023
| @@ -0,0 +1,135 @@ | |||
| package agentseed | |||
There was a problem hiding this comment.
Is there a way to make this work for otelcol.exporter.* components?
There was a problem hiding this comment.
Unclear at present. I'd assume there's some mechanism for including metadata, even though it may not be over http. Needs more research.
jcreixell
reviewed
Dec 19, 2023
jcreixell
reviewed
Dec 19, 2023
jcreixell
reviewed
Dec 19, 2023
jcreixell
approved these changes
Dec 20, 2023
captncraig
changed the title
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Jan 6, 2024
* pull out agentseed package for reading and storing uuid. Also put it in data dir for flow. * add uid header to prometheus.remote_write and loki.write * init func * cleaner api with fewer edge cases * add to pyroscope * compile * add to static remote write * add to static mode loki write * remove return from write. we never need it. * move loki write out of convert function * move out of prometheus convert function * static prom, get out of defaults function * static logs: take out of defaults function * constant for header. Work done in init with sync.once. Hardening * added some tests * maybe fix tests * testmain? * changelog
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* pull out agentseed package for reading and storing uuid. Also put it in data dir for flow. * add uid header to prometheus.remote_write and loki.write * init func * cleaner api with fewer edge cases * add to pyroscope * compile * add to static remote write * add to static mode loki write * remove return from write. we never need it. * move loki write out of convert function * move out of prometheus convert function * static prom, get out of defaults function * static logs: take out of defaults function * constant for header. Work done in init with sync.once. Hardening * added some tests * maybe fix tests * testmain? * changelog
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactorings to agent seed handling
internal/agentseedpackage that can be used anywhere.Getapi. If we cannot read or write the file, worst case is we generate a new uid and use it only for the lifetime of this process.UID to outbound headers
X-Agent-IDheader to outbound reequests fromprometheus.remote_writeloki.writepyroscope.writeThis header will be sent in the http headers only to remote writes you have configured.