Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: re-enable K8s-related unit tests (#5944)" #6000

Merged
merged 1 commit into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions component/remote/vault/vault_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ func Test_PollSecrets(t *testing.T) {
}

func getTestVaultServer(t *testing.T) *vaultapi.Client {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
ctx := componenttest.TestContext(t)
l := util.TestLogger(t)

Expand Down
3 changes: 3 additions & 0 deletions pkg/operator/build_hierarchy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ import (
// Test_buildHierarchy checks that an entire resource hierarchy can be
// discovered.
func Test_buildHierarchy(t *testing.T) {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
var wg sync.WaitGroup
defer wg.Wait()

Expand Down
3 changes: 3 additions & 0 deletions pkg/operator/hierarchy/hierarchy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import (
// TestNotifier tests that notifier properly handles events for changed
// objects.
func TestNotifier(t *testing.T) {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
l := log.NewNopLogger()

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
Expand Down
3 changes: 3 additions & 0 deletions pkg/operator/kubelet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ import (

// TestKubelet tests the Kubelet reconciler.
func TestKubelet(t *testing.T) {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
l := util.TestLogger(t)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
Expand Down
3 changes: 3 additions & 0 deletions pkg/operator/operator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ func ReconcileTest(ctx context.Context, t *testing.T, inFile, outFile string) {
// NewTestCluster creates a new testing cluster. The cluster will be removed
// when the test completes.
func NewTestCluster(ctx context.Context, t *testing.T, l log.Logger) *k8s.Cluster {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
t.Helper()

cluster, err := k8s.NewCluster(ctx, k8s.Options{})
Expand Down
3 changes: 3 additions & 0 deletions pkg/util/k8s/k8s_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ import (
)

func TestCluster(t *testing.T) {
// TODO: this is broken with go 1.20.6
// waiting on https://github.com/testcontainers/testcontainers-go/issues/1359
t.Skip()
ctx := context.Background()

cluster, err := NewCluster(ctx, Options{})
Expand Down