-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server/http): allow Basic Auth to be configurable for web UI #6018
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
b251145
to
51ad846
Compare
Co-authored-by: James (Anh-Tu) Nguyen <tunguyen9889@users.noreply.github.com>
7ec51ec
to
6555331
Compare
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes are really small in this PR. OK as-is
@grafana/grafana-agent-maintainers This probably needs a once-over by the dev team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there 👋 While this looks promising, we'd like to hold off of it for now after some discussion.
The rationale is that for common deployment methods, it's easy enough to achieve the same functionality with a separate layer (eg. using some authentication proxy or mLTS).
I like how we've contained everything to the UI service in this PR, but maintaining this Agent-side would eventually mean adding more authentication methods and/or extending it to the HTTP service which requires some more care.
If we decide to revisit, we could certainly revive this PR and use it as the base!
Sure! I have no issue with having this frozen. Please help relaying to the issue opener as well 🤗 |
PR Description
Which issue(s) this PR fixes
Fixes grafana/alloy#456
Notes to the Reviewer
PR Checklist