Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/http): allow Basic Auth to be configurable for web UI #6018

Closed
wants to merge 9 commits into from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Dec 22, 2023

PR Description

Which issue(s) this PR fixes

Fixes grafana/alloy#456

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

Sorry, something went wrong.

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber force-pushed the basic-auth-for-web-ui branch from b251145 to 51ad846 Compare December 22, 2023 17:33
Co-authored-by: James (Anh-Tu) Nguyen <tunguyen9889@users.noreply.github.com>
@hainenber hainenber force-pushed the basic-auth-for-web-ui branch from 7ec51ec to 6555331 Compare January 6, 2024 07:57
@hainenber
Copy link
Contributor Author

Basic Auth creds are prompted when trying to access agent's web UI, including component routes

image
image

Operational routes, i.e. /debug/pprof, /metrics, /-/ready and alikes are left alone
image
image
image

@hainenber hainenber marked this pull request as ready for review January 6, 2024 08:25
hainenber and others added 4 commits January 6, 2024 15:28
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 9, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes are really small in this PR. OK as-is

@clayton-cornell clayton-cornell requested a review from a team January 12, 2024 17:26
@clayton-cornell
Copy link
Contributor

@grafana/grafana-agent-maintainers This probably needs a once-over by the dev team

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there 👋 While this looks promising, we'd like to hold off of it for now after some discussion.

The rationale is that for common deployment methods, it's easy enough to achieve the same functionality with a separate layer (eg. using some authentication proxy or mLTS).

I like how we've contained everything to the UI service in this PR, but maintaining this Agent-side would eventually mean adding more authentication methods and/or extending it to the HTTP service which requires some more care.

If we decide to revisit, we could certainly revive this PR and use it as the base!

@hainenber
Copy link
Contributor Author

Sure! I have no issue with having this frozen. Please help relaying to the issue opener as well 🤗

@hainenber hainenber closed this Jan 17, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Auth Basic to Grafana Agent API
4 participants