helm: clean up logic for autodelete pvcs #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
approved these changes
Jan 3, 2024
Comment on lines
192
to
193
| # -- The StatefulSetAutoDeletePVC feature gate went into alpha status with k8s 1.27. If you have it enabled on an earlier version, you can lower this value as far as 1.23. | ||
| minK8sVersionForAutoDelete: ">= 1.27" |
There was a problem hiding this comment.
I'm looking at what other Helm charts do here to remove the need for another option. It looks like the Loki chart only checks for 1.23. I see a similar check in the Consul Helm chert.
Ideally we'd avoid a new config option here, and rely on documentation on enableStatefulSetAutoDeletePVC, where we mention it's a feature gate from 1.23 to 1.26, and generally available afterwards.
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Jan 6, 2024
* helm: clean up logic for autodelete pvcs * remove flag * changelog
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* helm: clean up logic for autodelete pvcs * remove flag * changelog
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist