Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus.exporter.kafka: use correct secret type #6046

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 4, 2024

Use rivertypes.Secret for sensitive fields instead of Prometheus' secret type.

I checked other components for this specific issue and didn't find anything.

Fixes #6044.

Use rivertypes.Secret for sensitive fields instead of Prometheus' secret
type.

Fixes grafana#6044.
@rfratto rfratto requested a review from marctc January 4, 2024 13:14
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the converter, but this LGTM.

@rfratto rfratto enabled auto-merge (squash) January 4, 2024 13:41
@rfratto rfratto merged commit 6e4a9b9 into grafana:main Jan 4, 2024
10 checks passed
@rfratto rfratto deleted the fix-crash-prometheus.exporter.kafka branch January 4, 2024 14:05
hainenber pushed a commit to hainenber/agent that referenced this pull request Jan 6, 2024
Use rivertypes.Secret for sensitive fields instead of Prometheus' secret
type.

Fixes grafana#6044.
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
Use rivertypes.Secret for sensitive fields instead of Prometheus' secret
type.

Fixes grafana#6044.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka exporter: panic: reflect.Set: value of type string is not assignable to type config.Secret
2 participants