Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create migrate tasks subdirectory #6051

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Create migrate tasks subdirectory #6051

merged 1 commit into from
Jan 5, 2024

Conversation

thampiotr
Copy link
Contributor

PR Description

This just creates a Migrate tasks subdirectory to better organise them.

image
  • Checked for warnings and there are no broken links.
  • Not creating new backwards-compatible aliases for previous location, because the pages I'm moving here were at their new location only for about 1h as of this writing: Move 'Getting started' to 'Tasks' #6043.

@thampiotr thampiotr marked this pull request as ready for review January 5, 2024 11:05
ptodev
ptodev approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer to merge this either after @clayton-cornell approves, or after the RC is cut (so that Clayton can opine what he's back).

@thampiotr
Copy link
Contributor Author

Discussed offline with Paulin. Given that these links were short lived and recent changes, we prefer to merge this rather sooner than later. I'll merge now. If any issues come up, we'll clean up when Clayton is back. Thanks for review!

@thampiotr thampiotr merged commit d8efe1a into main Jan 5, 2024
10 checks passed
@thampiotr thampiotr deleted the thampiotr/docs-reorg-4 branch January 5, 2024 13:33
hainenber pushed a commit to hainenber/agent that referenced this pull request Jan 6, 2024
@thampiotr @hainenber
create migrate tasks subdirectory (grafana#6051)
30323f3
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 8, 2024
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@thampiotr @BarunKGP
create migrate tasks subdirectory (grafana#6051)
e3ce940
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ptodev ptodev ptodev approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thampiotr @ptodev @clayton-cornell