loki.source.docker: deduplicate matching container IDs #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
tpaschalis
force-pushed
the
loki-source-docker-unique-targets
branch
from
6624847 to
7348a5c
Compare
Signed-off-by: Paschalis Tsilias <[email protected]>
rfratto
approved these changes
Jan 5, 2024
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
I've added a paragraph to document this new behavior, hopefully it clears things up. |
rfratto
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
LGTM but the docs change should get a review by @clayton-cornell
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
added
the
type/docs
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Paschalis Tsilias <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The
discovery.dockercomponent was initially built with Prometheus service discovery in mind; this means that it will report a different target for each port, network and network interface that a container exposes/belongs to, so that it can be scraped accordingly.This means, that when
discovery.dockeris used as an input to loki.source.docker, it will set up unnecessary load on the Docker API by trying to fetch logs for the same container ID multiple times. This PR makes it so that during a component Update, the targets are deduplicated based on the container ID, keeping only the first one.Which issue(s) this PR fixes
Related to: #4403
I'd like to gather some more evidence until we say this fixes #4403 outright, so keeping this PR in draft in the meantime.
Notes to the Reviewer
I've run a simplistic benchmark with a chatty container that exposes two ports, and as expected, the CPU time spent on reading logs is ~half here.
PR Checklist