Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm/chart/template): set namespace for RBAC's service account #6061

Conversation

hainenber
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Fixes #6040

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@rfratto rfratto self-assigned this Jan 8, 2024
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rfratto rfratto enabled auto-merge (squash) January 8, 2024 18:42
@rfratto rfratto merged commit 9e6545d into grafana:main Jan 8, 2024
10 checks passed
@hainenber hainenber deleted the configure-namespace-for-srv-acc-when-create-rbac branch January 9, 2024 01:38
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm templating inconsistency with --namespace flag
2 participants