fix(otelcol): fix Prometheus exporter not collecting metrics after reload #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
changed the title
tpaschalis
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thank you once more @hainenber 🙌
For posterity, I think the upstream fix was open-telemetry/opentelemetry-go#4648 and the original report was open-telemetry/opentelemetry-go#4032
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
…load (grafana#6154) Signed-off-by: hainenber <[email protected]> Co-authored-by: Paschalis Tsilias <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes OTEL metrics not getting collected after the Agent is reloaded. The fix has already arrived in
go.opentelemetry.io/otel/sdk/[email protected]Which issue(s) this PR fixes
Fixes #6140
Notes to the Reviewer
PR Checklist