Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mimir.rules.kubernetes externallabels #6769

Conversation

psychomantys
Copy link

@psychomantys psychomantys commented Mar 26, 2024

PR Description

Add support to inject external_labels to mimir.rules.kubernetes.

Which issue(s) this PR fixes

Fixes grafana/alloy#356
Fixes grafana/alloy#291

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@tpaschalis
Copy link
Member

Could this also apply to loki.rules.kubernetes?

@psychomantys
Copy link
Author

Could this also apply to loki.rules.kubernetes?

Sorry about that, during my initial commits, I mistakenly replaced mimir.rules.kubernetes with loki.rules.kubernetes. This was an unintentional error, but I have since corrected the commits, and everything now is in order. However, this may have caused some confusion. I want to assure you that the changes were made in error have been rectified, and the commit functionality is only applicable to mimir.rules.kubernetes, as originally intended.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Mar 27, 2024
@clayton-cornell clayton-cornell requested a review from a team March 27, 2024 22:59
@rfratto rfratto added the variant/flow Relatd to Grafana Agent Flow. label Apr 9, 2024
@clayton-cornell
Copy link
Contributor

@tpaschalis is there more to do here?

@psychomantys
Copy link
Author

Please feel free to reach me if any further questions or require additional modifications on this. I'd be delighted to assist and especially interested with the possibility of this into Alloy as well.

@mattdurham
Copy link
Collaborator

Looks good but would love to see some tests here.

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Jun 27, 2024
@ptodev
Copy link
Contributor

ptodev commented Jul 18, 2024

Hi, @psychomantys! I opened a PR for Alloy to support this feature. The Alloy PR is based on yours, and credits will go to you in the Alloy changelog. Thank you for your contribution! Since we are no longer adding new features to Grafana Agent, I will close this PR.

@ptodev ptodev closed this Jul 18, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Aug 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention. type/docs Docs Squad label across all Grafana Labs repos variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
7 participants