-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mimir.rules.kubernetes externallabels #6769
Feature/mimir.rules.kubernetes externallabels #6769
Conversation
Could this also apply to loki.rules.kubernetes? |
Sorry about that, during my initial commits, I mistakenly replaced |
@tpaschalis is there more to do here? |
Please feel free to reach me if any further questions or require additional modifications on this. I'd be delighted to assist and especially interested with the possibility of this into Alloy as well. |
Looks good but would love to see some tests here. |
This PR has not had any activity in the past 30 days, so the |
Hi, @psychomantys! I opened a PR for Alloy to support this feature. The Alloy PR is based on yours, and credits will go to you in the Alloy changelog. Thank you for your contribution! Since we are no longer adding new features to Grafana Agent, I will close this PR. |
PR Description
Add support to inject
external_labels
tomimir.rules.kubernetes
.Which issue(s) this PR fixes
Fixes grafana/alloy#356
Fixes grafana/alloy#291
PR Checklist