Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode and fix YAML indentation #6936

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented May 31, 2024

PR Description

Add mode and fix YAML indentation

Which issue(s) this PR fixes

Fixes #issue_id https://github.com/grafana/support-escalations/issues/10761

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.40 labels May 31, 2024
@clayton-cornell clayton-cornell requested a review from a team May 31, 2024 19:45
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the indendation change; the mode is inferred to be "flow" if not set but it's OK

@clayton-cornell clayton-cornell merged commit 6ead6f7 into main Jun 3, 2024
12 checks passed
@clayton-cornell clayton-cornell deleted the docs/fix-missing-info-example branch June 3, 2024 12:32
grafanabot pushed a commit that referenced this pull request Jun 3, 2024
clayton-cornell added a commit that referenced this pull request Jun 3, 2024
(cherry picked from commit 6ead6f7)

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jul 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.40 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants