rebase

internal/component/discovery/target_test.go

@@ -42,11 +42,16 @@ func TestDecodeMap(t *testing.T) {
 	get, ok := actual.Get("foo")
 	require.True(t, ok)
 	require.Equal(t, "bar", get)
-	
+
 	actual.Delete("foo")
 	get, ok = actual.Get("foo")
 	require.False(t, ok)
 	require.Equal(t, "", get)
+
+	// Some loggers print targets out, check it's all good. But without caring about order.
+	str := fmt.Sprintf("%s", actual)
+	valid := str == `{a="5", b="10"}` || str == `{b="10", a="5"}`
+	require.True(t, valid)
 }
 
 func TestConvertFromNative(t *testing.T) {

internal/component/pyroscope/java/java.go

@@ -126,9 +126,14 @@ func (j *javaComponent) updateTargets(args Arguments) {
 
 	active := make(map[int]struct{})
 	for _, target := range args.Targets {
-		pid64, err := strconv.ParseInt(target[labelProcessID], 10, 32)
+		pidStr, ok := target.Get(labelProcessID)
+		if !ok {
+			_ = level.Error(j.opts.Logger).Log("msg", "could not find PID label", "pid", pidStr)
+			continue
+		}
+		pid64, err := strconv.ParseInt(pidStr, 10, 32)
 		if err != nil {
-			_ = level.Error(j.opts.Logger).Log("msg", "could not convert process ID to a 32 bit integer", "pid", target[labelProcessID], "err", err)
+			_ = level.Error(j.opts.Logger).Log("msg", "could not convert process ID to a 32 bit integer", "pid", pidStr, "err", err)
 			continue
 		}
 		pid := int(pid64)