Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Extra Manifest Objects #1061

Closed
wants to merge 8 commits into from
Closed

add support for Extra Manifest Objects #1061

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2024

PR Description

Adds the ability to provide additional adhoc Kubernetes manifests.
One of my use cases was injecting ConfigMaps to be mounted as volumes, this could simplify adding dependencies when deploying Alloy.

For example:

controller:
  volumes:
    extra:
      - name: test-volume
        configMap:
          name: hosts
alloy:
  mounts:
    extra:
      - name: test-volume
        mountPath: /etc/test

extraObjects:
  - apiVersion: v1
    kind: ConfigMap
    metadata:
      name: hosts
    data:
      conf.ini: |-
        [hosts]
        localhost = 127.0.0.1

Which issue(s) this PR fixes

n/a

Notes to the Reviewer

It seemed reasonable to me to add the property at root level.
No changelog
No version updated
[x] tested locally

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ghost ghost requested a review from rfratto June 17, 2024 20:23
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2024

CLA assistant check
All committers have signed the CLA.

@ghost ghost requested review from a team and removed request for rfratto July 20, 2024 19:46
@ghost ghost closed this by deleting the head repository Oct 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant