-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace dependency on unexported otelcol functions #2148
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you! I didn't realise that it's possible to do this 😆 I thought the public OTel functions only allow generating the config from a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Would you like to also do the same change to the Agent?
We won't be able to rid of the fork entirely, but it'll help - there will be less things to modify on the fork when we upgrade it.
@ptodev I don't believe that we are planning on updating the Otel version for the Agent |
I suppose so, but we might have to, you never know :) |
I don't insist on the change being done on the Agent. I'll leave it up to @dehaansa to decide if it's worth his effort. Maybe it's too much risk for too little benefit. |
We already use a custom version of the fork for the agent because of some CVEs (see https://github.com/grafana/agent/blob/main/go.mod#L777) so to get rid of the fork we would either need to copy some more code or we would need to upgrade the Otel version at the same time to get the CVEs fix. |
PR Description
Inspired by #1023 - replacing the call to an unexported function to utilizing the intended functionality from otelcol.