Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cortex-tool analyse to handle more panel types and queries #231

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ttk
Copy link

@ttk ttk commented Dec 21, 2021

I found that cortex-tool was generating a lot of errors in when analyzing our grafana instance with 300+ dashboards, where 75% of the dashboards had some parse error. We are using Grafana v8.2.3.

This MR basically eliminated all the errors I encountered when trying to analyse our grafana instance. There's a bit of voodoo when doing the regex variable replacement, but through trial and error I found a few rules that allow the parser to succeed so that the metric names can be extracted.

@ttk ttk requested a review from a team as a code owner December 21, 2021 00:03
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
Signed-off-by: Renovate Bot <[email protected]>

Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants