Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List used labels by metric in grafana #256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

List used labels by metric in grafana #256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
179e778
List used labels by metric in grafana
IuryAlves Jul 21, 2022
899152c
Fix lint
IuryAlves Jul 21, 2022
adfe5cd
Ignore label values, only get the label names
IuryAlves Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions pkg/analyse/grafana.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@ type MetricsInGrafana struct {
}

type DashboardMetrics struct {
Slug string `json:"slug"`
UID string `json:"uid,omitempty"`
Title string `json:"title"`
Metrics []string `json:"metrics"`
ParseErrors []string `json:"parse_errors"`
Slug string `json:"slug"`
UID string `json:"uid,omitempty"`
Title string `json:"title"`
Metrics []string `json:"metrics"`
LabelsByMetric map[string][]string `json:"labels_by_metric"`
ParseErrors []string `json:"parse_errors"`
}

func ParseMetricsInBoard(mig *MetricsInGrafana, board sdk.Board) {
var parseErrors []error
metrics := make(map[string]struct{})
metrics := make(map[string][]string)

// Iterate through all the panels and collect metrics
for _, panel := range board.Panels {
Expand Down Expand Up @@ -68,17 +69,18 @@ func ParseMetricsInBoard(mig *MetricsInGrafana, board sdk.Board) {
sort.Strings(metricsInBoard)

mig.Dashboards = append(mig.Dashboards, DashboardMetrics{
Slug: board.Slug,
UID: board.UID,
Title: board.Title,
Metrics: metricsInBoard,
ParseErrors: parseErrs,
Slug: board.Slug,
UID: board.UID,
Title: board.Title,
Metrics: metricsInBoard,
ParseErrors: parseErrs,
LabelsByMetric: metrics,
})

}

func metricsFromTemplating(templating sdk.Templating, metrics map[string]struct{}) []error {
parseErrors := []error{}
func metricsFromTemplating(templating sdk.Templating, metrics map[string][]string) []error {
var parseErrors []error
for _, templateVar := range templating.List {
if templateVar.Type != "query" {
continue
Expand Down Expand Up @@ -114,7 +116,7 @@ func metricsFromTemplating(templating sdk.Templating, metrics map[string]struct{
return parseErrors
}

func metricsFromPanel(panel sdk.Panel, metrics map[string]struct{}) []error {
func metricsFromPanel(panel sdk.Panel, metrics map[string][]string) []error {
var parseErrors []error

targets := panel.GetTargets()
Expand All @@ -140,7 +142,7 @@ func metricsFromPanel(panel sdk.Panel, metrics map[string]struct{}) []error {
return parseErrors
}

func parseQuery(query string, metrics map[string]struct{}) error {
func parseQuery(query string, metrics map[string][]string) error {
query = strings.ReplaceAll(query, `$__interval`, "5m")
query = strings.ReplaceAll(query, `$interval`, "5m")
query = strings.ReplaceAll(query, `$resolution`, "5s")
Expand All @@ -154,8 +156,21 @@ func parseQuery(query string, metrics map[string]struct{}) error {
}

parser.Inspect(expr, func(node parser.Node, path []parser.Node) error {
var labels []string

if n, ok := node.(*parser.VectorSelector); ok {
metrics[n.Name] = struct{}{}
for _, l := range n.LabelMatchers {
// ignore meta label __name__
if l.Name == "__name__" {
continue
}
labels = append(
labels,
l.Name,
)
}
metrics[n.Name] = labels

}

return nil
Expand Down