Fix: Use Patch instead of Update to add/remove finalizers #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
fix_finalizer_cfg_drift
branch
from
172cf54 to
1fa382c
Compare
Baarsgaard
changed the title
weisdd
requested changes
Dec 21, 2024
Baarsgaard
force-pushed
the
fix_finalizer_cfg_drift
branch
2 times, most recently
from
cdde804 to
b778a52
Compare
|
Once this is merged, I will likely add finalizers to |
Baarsgaard
force-pushed
the
fix_finalizer_cfg_drift
branch
from
b778a52 to
a99dc26
Compare
weisdd
requested changes
Dec 30, 2024
weisdd
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed to solve the perpetual drift noted in #1776 that is rooted in us applying finalizers and updating unintended fields on CRs.
I first attempted to use
JSONPatch, but I could not for the life of me get the libraries to comply, despite handcrafting working patches with kubectl.MergePatchworked immediately.Currently, the implementation is hardcoded to only support arrays of one finalizer. More work can be done to make this support multiple if the need ever arises.