Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Update GrafanaAlertRuleGroup reconcile loop #1827

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Refactor: Update GrafanaAlertRuleGroup reconcile loop #1827

merged 3 commits into from
Jan 21, 2025

Conversation

Baarsgaard
Copy link
Contributor

  • Fix: Warnings when returning ctrl.Result and an error and logging some errors twice.
  • Feat: status.lastResync is now updated and registered as a printed column
  • Refactor: Use GetScopedMatchingInstances for Reconcile and finalize

@Baarsgaard Baarsgaard marked this pull request as ready for review January 16, 2025 21:38
@theSuess theSuess added the refactor this PR refactors code without introducing functionality label Jan 21, 2025
@theSuess theSuess added this pull request to the merge queue Jan 21, 2025
Merged via the queue into grafana:master with commit 01fe38f Jan 21, 2025
15 checks passed
@Baarsgaard Baarsgaard deleted the update_alertrulegroup_reconcile_loop branch January 21, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
refactor this PR refactors code without introducing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baarsgaard @theSuess