App-With-On-Behalf-Of: Set extended_jwt conf in docker-compose
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
approved these changes
Oct 25, 2023
Comment on lines
18
to
20
| COPY extended_jwt.ini /tmp/extended_jwt.ini | ||
| RUN cat /tmp/extended_jwt.ini >> /etc/grafana/grafana.ini |
There was a problem hiding this comment.
I guess you could also copy the file as custom.ini? In any case both works so it's fine
gamab
changed the title
extended_jwt conf in grafana ini fileextended_jwt conf
gamab
changed the title
extended_jwt confextended_jwt conf in docker-compose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extended_jwtconfig options are not overridable with env variables.There were multiple ways of tackling this:
custom.inifile and using it instead of/etc/grafana/grafana.iniextended_jwtconfig to the/etc/grafana/grafana.iniI chose the last option so that it works withgrafana:mainalready but also because we won't need to update thecustom.inifile with grafana version increases.On second thought, since we have to wait for
10.3.0anyway, using env overrides is cleaner ( grafana/grafana#77132 )