Docs: Edit example README and add comments in Basic Panel Plugin #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josmperez
requested review from
mckn,
wbrowne,
andresmgot,
oshirohugo and
jackw
and removed request for
a team
josmperez
changed the title
josmperez
changed the title
academo
reviewed
Jan 2, 2024
academo
reviewed
Jan 2, 2024
academo
reviewed
Jan 2, 2024
academo
reviewed
Jan 2, 2024
examples/panel-basic/src/components/SimplePanel/SimplePanel.tsx
Outdated
Show resolved
Hide resolved
academo
reviewed
Jan 2, 2024
examples/panel-basic/src/components/SimplePanel/SimplePanel.tsx
Outdated
Show resolved
Hide resolved
mckn
reviewed
Jan 9, 2024
examples/panel-basic/src/components/SimplePanel/SimplePanel.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export function SimplePanel({ | ||
| options, | ||
| export function SimplePanel({ /** Takes in a list of props used in this example */ |
There was a problem hiding this comment.
Suggested change
| export function SimplePanel({ /** Takes in a list of props used in this example */ | |
| export function SimplePanel({ |
examples/panel-basic/src/components/SimplePanel/SimplePanel.tsx
Outdated
Show resolved
Hide resolved
academo
reviewed
Jan 19, 2024
academo
reviewed
Jan 19, 2024
academo
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
@josmperez I pushed a commit fixing the npm commands and the rest looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit example README and add some code comments for Panel Basic Plugin template.