This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhowe
force-pushed
the
add-timeseries
branch
6 times, most recently
from
August 7, 2022 08:11
96844c0
to
1f9f002
Compare
tenstad
reviewed
Aug 17, 2022
rhowe
force-pushed
the
add-timeseries
branch
2 times, most recently
from
August 18, 2022 09:17
8d3c2cc
to
0e5f0bd
Compare
@malcolmholmes sorry to be a pain, and I know grafonnet isn't exactly an active project these days but what are the chances of this PR getting a review? |
@rhowe Agreed, I would absolutely love having timeseries compatibility :) |
@malcolmholmes same here! this would be incredibly useful |
If you want this, please don't continue to spam a Grafana engineer with comments (yes, OK, I know, I started it, but we don't all need to do it). Just add a 👍 to the MR Also there's nothing stopping you taking the code from my branch and using it yourself, even if it's not in the main grafonnet repo. |
rhowe
force-pushed
the
add-timeseries
branch
2 times, most recently
from
September 30, 2022 20:02
f1b7e21
to
446015b
Compare
rhowe
force-pushed
the
add-timeseries
branch
2 times, most recently
from
October 9, 2022 08:30
b020d8f
to
f7d5097
Compare
- jsonnet to 18 - cypress to 10.9 - grafana to 9.2.1
rhowe
force-pushed
the
add-timeseries
branch
2 times, most recently
from
October 23, 2022 09:01
a334037
to
9b935b5
Compare
This is based on the behaviour of Grafana 9.0.5
See new README. This repo is deprecated. The new Grafonnet has support for the timeseries panel (https://github.com/grafana/grafonnet) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the behaviour of Grafana 9.0.5
It should address #358 and #352
Upgrade the e2e tests to work with Grafana 9.x
Fixes #363
Note that I haven't used cypress before and I work hard to avoid node, so this might not be quite right.
I added a
Makefile
target for runningnpm install
to allow upgrading Cypress without relying on a local Nodejs install.Somehow I missed the fact the repo had tests until I was too far down the rabbit hole writing the tests in a different style, hope that's OK.