Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel to 7.11.6. #1663

Closed
wants to merge 4 commits into from
Closed

Update babel to 7.11.6. #1663

wants to merge 4 commits into from

Conversation

legander
Copy link
Contributor

@legander legander commented Oct 8, 2020

Update babel from [6.26.0, preset=latest] to [7.11.6, preset=env].

  • Improving transpile time quite significantly for large scripts.
  • Needs some testing to ensure same level of ES feature support as previous build.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #1663 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   72.15%   72.10%   -0.05%     
==========================================
  Files         166      167       +1     
  Lines       12787    12884      +97     
==========================================
+ Hits         9226     9290      +64     
- Misses       3011     3030      +19     
- Partials      550      564      +14     
Flag Coverage Δ
#ubuntu 72.06% <0.00%> (?)
#windows 70.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/compiler/compiler.go 73.58% <0.00%> (-2.89%) ⬇️
js/compiler/rice-box.go 100.00% <ø> (ø)
stats/statsd/collector.go 65.21% <0.00%> (-34.79%) ⬇️
stats/datadog/collector.go 74.19% <0.00%> (-25.81%) ⬇️
cmd/options.go 61.43% <0.00%> (-1.76%) ⬇️
cmd/collectors.go 0.00% <0.00%> (ø)
lib/netext/httpext/response.go 91.11% <0.00%> (ø)
stats/statsd/common/collector.go 81.92% <0.00%> (ø)
stats/statsd/common/config.go
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66574f...dd927cb. Read the comment docs.

@legander legander requested a review from mstoykov October 12, 2020 09:20
@mstoykov mstoykov added this to the v0.30.0 milestone Nov 4, 2020
@mstoykov mstoykov self-assigned this Nov 4, 2020
@na-- na-- modified the milestones: v0.30.0, v0.31.0 Jan 12, 2021
@na-- na-- removed this from the v0.31.0 milestone Feb 24, 2021
@na--
Copy link
Member

na-- commented Apr 7, 2021

With the latest changes in goja (native support block-scoped variables, added in dop251/goja#264 and adopted in #1904), we are probably not going to update babel soon - we no longer have issues with k6 archive taking forever on long scripts... So I'll close this issue, cc @sniku.

In any case, if we want to update babel, we'll definitely need another PR, because:

@na-- na-- closed this Apr 7, 2021
@na-- na-- deleted the chore/update-babel branch April 7, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants