Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update goja to let-const branch #1867

Closed
wants to merge 3 commits into from
Closed

update goja to let-const branch #1867

wants to merge 3 commits into from

Conversation

mstoykov
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #1867 (0eb8ad9) into master (a85664b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
+ Coverage   71.48%   71.52%   +0.04%     
==========================================
  Files         180      180              
  Lines       13969    13969              
==========================================
+ Hits         9986     9992       +6     
+ Misses       3346     3340       -6     
  Partials      637      637              
Flag Coverage Δ
ubuntu 71.47% <ø> (+0.02%) ⬆️
windows 71.11% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/compiler/compiler.go 67.24% <ø> (ø)
lib/executor/vu_handle.go 95.23% <0.00%> (+1.90%) ⬆️
core/engine.go 93.03% <0.00%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85664b...84efd21. Read the comment docs.

@na-- na-- added this to the v0.32.0 milestone Mar 10, 2021
@na--
Copy link
Member

na-- commented Mar 15, 2021

This seems like it should be closed in favor of #1904?

@na-- na-- closed this Mar 15, 2021
@mstoykov mstoykov deleted the testingLetConst branch August 11, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants