Create new http.TargetServer
shared across all HTTP Promtail Targets
#9181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR creates a wrapper around WeaveWorks HTTP server, to be able to re-use some common configuration all Promtail targets that expose and HTTP server do.
From all the targets: gcp logs push, heroku and lokipush expose and HTTP server, based on WeaveWorks. They all have some repeated logic that:
By extracting a common
TargetServer
, we can share all that configuration procedure, delegating to each target itself configuring just the HTTP handlers..Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
lokipush was not pulled in the new wrapped sever, since it handles some configurations differently. Leaving as a follow up.
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updateddocs/sources/upgrading/_index.md