remove all references to deprecated AlertGroup.is_restricted field (#…

…3228)

# What this PR does

remove all references to deprecated `AlertGroup.is_restricted` field +
leave a note to remove the column in a future release

engine/apps/alerts/escalation_snapshot/escalation_snapshot_mixin.py

@@ -247,10 +247,9 @@ def start_escalation_if_needed(self, countdown=START_ESCALATION_DELAY, eta=None)
 
         is_on_maintenance_or_debug_mode = self.channel.maintenance_mode is not None
 
-        if self.is_restricted or is_on_maintenance_or_debug_mode or not self.escalation_chain_exists:
+        if is_on_maintenance_or_debug_mode or not self.escalation_chain_exists:
             logger.debug(
                 f"Not escalating alert group w/ pk: {self.pk}\n"
-                f"is_restricted: {self.is_restricted}\n"
                 f"is_on_maintenance_or_debug_mode: {is_on_maintenance_or_debug_mode}\n"
                 f"escalation_chain_exists: {self.escalation_chain_exists}"
             )

engine/apps/alerts/incident_appearance/renderers/classic_markdown_renderer.py

@@ -1,6 +1,5 @@
 from apps.alerts.incident_appearance.renderers.base_renderer import AlertBaseRenderer, AlertGroupBaseRenderer
 from apps.alerts.incident_appearance.templaters import AlertClassicMarkdownTemplater
-from common.constants.alert_group_restrictions import IS_RESTRICTED_MESSAGE, IS_RESTRICTED_TITLE
 from common.utils import str_or_backup
 
 
@@ -11,13 +10,11 @@ def templater_class(self):
 
     def render(self):
         templated_alert = self.templated_alert
-        is_restricted = self.alert.group.is_restricted
-
         return {
-            "title": IS_RESTRICTED_TITLE if is_restricted else str_or_backup(templated_alert.title, "Alert"),
-            "message": IS_RESTRICTED_MESSAGE if is_restricted else str_or_backup(templated_alert.message, ""),
-            "image_url": None if is_restricted else str_or_backup(templated_alert.image_url, None),
-            "source_link": None if is_restricted else str_or_backup(templated_alert.source_link, None),
+            "title": str_or_backup(templated_alert.title, "Alert"),
+            "message": str_or_backup(templated_alert.message, ""),
+            "image_url": str_or_backup(templated_alert.image_url, None),
+            "source_link": str_or_backup(templated_alert.source_link, None),
         }
 
 

engine/apps/alerts/incident_appearance/renderers/web_renderer.py

@@ -1,6 +1,5 @@
 from apps.alerts.incident_appearance.renderers.base_renderer import AlertBaseRenderer, AlertGroupBaseRenderer
 from apps.alerts.incident_appearance.templaters import AlertWebTemplater
-from common.constants.alert_group_restrictions import IS_RESTRICTED_MESSAGE, IS_RESTRICTED_TITLE
 from common.utils import str_or_backup
 
 
@@ -11,13 +10,11 @@ def templater_class(self):
 
     def render(self):
         templated_alert = self.templated_alert
-        is_restricted = self.alert.group.is_restricted
-
         return {
-            "title": IS_RESTRICTED_TITLE if is_restricted else str_or_backup(templated_alert.title, "Alert"),
-            "message": IS_RESTRICTED_MESSAGE if is_restricted else str_or_backup(templated_alert.message, ""),
-            "image_url": None if is_restricted else str_or_backup(templated_alert.image_url, None),
-            "source_link": None if is_restricted else str_or_backup(templated_alert.source_link, None),
+            "title": str_or_backup(templated_alert.title, "Alert"),
+            "message": str_or_backup(templated_alert.message, ""),
+            "image_url": str_or_backup(templated_alert.image_url, None),
+            "source_link": str_or_backup(templated_alert.source_link, None),
         }
 
 

engine/apps/alerts/models/alert_group.py

@@ -389,6 +389,7 @@ def status(self):
     # https://code.djangoproject.com/ticket/28545
     is_open_for_grouping = models.BooleanField(default=None, null=True, blank=True)
 
+    # TODO: drop this column in an upcoming release
     is_restricted = models.BooleanField(default=False, null=True)
 
     @staticmethod

engine/apps/api/serializers/alert.py

@@ -71,5 +71,4 @@ class Meta:
         ]
 
     def get_raw_request_data(self, obj):
-        # TODO:
-        return {} if obj.group.is_restricted else obj.raw_request_data
+        return obj.raw_request_data

engine/apps/api/serializers/alert_group.py

@@ -149,7 +149,6 @@ class Meta:
             "status",
             "declare_incident_link",
             "team",
-            "is_restricted",
         ]
 
     @extend_schema_field(

engine/apps/public_api/serializers/alerts.py

@@ -21,4 +21,4 @@ class Meta:
         ]
 
     def get_payload(self, obj):
-        return {} if obj.group.is_restricted else obj.raw_request_data
+        return obj.raw_request_data

engine/apps/public_api/serializers/incidents.py

@@ -4,7 +4,6 @@
 from apps.alerts.models import AlertGroup
 from apps.telegram.models.message import TelegramMessage
 from common.api_helpers.mixins import EagerLoadingMixin
-from common.constants.alert_group_restrictions import IS_RESTRICTED_TITLE
 
 
 class IncidentSerializer(EagerLoadingMixin, serializers.ModelSerializer):
@@ -42,7 +41,7 @@ class Meta:
         ]
 
     def get_title(self, obj):
-        return IS_RESTRICTED_TITLE if obj.is_restricted else obj.web_title_cache
+        return obj.web_title_cache
 
     def get_alerts_count(self, obj):
         return len(obj.alerts.all())