Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error encoding on install_v2 endpoint #5133

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Oct 7, 2024

What this PR does

Fixes incorrect encoding when SyncException contains one of the predefined dataclass errors in install_v2 endpoint.

Which issue(s) this PR closes

Related to #5124

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@mderynck mderynck added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Oct 7, 2024
@mderynck mderynck requested a review from a team October 7, 2024 19:53
@mderynck mderynck added this pull request to the merge queue Oct 7, 2024
Merged via the queue into dev with commit 5cf382a Oct 7, 2024
31 checks passed
@mderynck mderynck deleted the mderynck/fix-install-v2-error-encoding branch October 7, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants