Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tags only workflow behavior #5404

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 8, 2025

What this PR does

Without this, the action assumes there is a release branch that a tag is made on because that is common to most other Grafana repositories. Those repositories maintain a long-lived release branch to facilitate backports to documentation and code.

Since grafana/oncall doesn't follow this pattern, it doesn't make sense to try and discover the matching release branch. That action behavior is disabled by the tags_only: true setting.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

Without this, the action assumes there is a release branch that a tag is made on because that is common to most other Grafana repositories.
Those repositories maintain a long-lived release branch to facilitate backports to documentation and code.

Since grafana/oncall doesn't follow this pattern, it doesn't make sense to try and discover the matching release branch.
That action behavior is disabled by the `tags_only: true` setting.

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Jan 8, 2025
@jdbaldry jdbaldry requested a review from joeyorlando January 8, 2025 09:57
@joeyorlando joeyorlando added this pull request to the merge queue Jan 8, 2025
Merged via the queue into dev with commit 6e75374 Jan 8, 2025
30 checks passed
@joeyorlando joeyorlando deleted the jdb/2025-01-use-tags-only-workflow branch January 8, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants