Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to async-profiler 3.0 #139

Merged
merged 10 commits into from
Jan 29, 2024
Merged

update to async-profiler 3.0 #139

merged 10 commits into from
Jan 29, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Jan 25, 2024

upstream has a single binary for musl/glibc, I could not make it work with stdlibc++ static linking so we still have separate binaries for musl/libc.
Otherwise no changes were made, only some integration tests are added.

Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added a few minor remarks.

async-profiler-context/build.gradle Outdated Show resolved Hide resolved
demo/src/main/java/Fib.java Outdated Show resolved Hide resolved
alpine-test.Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.class files are normally not added to Git, was this intentional here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is convenient for me for debugging purposes. I found myself spawning numerous docker containers and doing javac Fib.java + java Fib, now I only need one :). This is only for debugging/development. One class file would not hurt so I decided to add it.

@korniltsev korniltsev merged commit e435a88 into main Jan 29, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants