-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to async-profiler 3.0 #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, added a few minor remarks.
demo/src/main/java/Fib.class
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.class
files are normally not added to Git, was this intentional here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this is convenient for me for debugging purposes. I found myself spawning numerous docker containers and doing javac Fib.java + java Fib, now I only need one :). This is only for debugging/development. One class file would not hurt so I decided to add it.
upstream has a single binary for musl/glibc, I could not make it work with stdlibc++ static linking so we still have separate binaries for musl/libc.
Otherwise no changes were made, only some integration tests are added.