Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the release pipeline to a GitHub action #171

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Move the release pipeline to a GitHub action #171

merged 10 commits into from
Nov 28, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Nov 27, 2024 •
edited
Loading

For reference, the current Jenkins job looks somewhat like this

set -e

GIT_COMMIT=$(git rev-parse $reference)

echo "releasing $GIT_COMMIT"

git config user.name <redacted>
git config user.email <redacted>

git checkout -b main

sed -i "s/pyroscope_version=.*/pyroscope_version=$version/" gradle.properties

# make build # publish only to github
make publish

git add gradle.properties
git commit -m "version $version"
git tag "v$version" 
git push --atomic origin "refs/heads/main"  "refs/tags/v$version" 

gh release create "v$version" --title '' --notes ''
gh release upload "v$version" agent/build/libs/pyroscope.jar

@aleks-p aleks-p requested review from a team as code owners November 27, 2024 20:23
aleks-p
aleks-p commented Nov 27, 2024
View reviewed changes
Makefile
@@ -15,7 +15,6 @@ publish:
-Psigning.secretKeyRingFile="$(NEXUS_GPG_SECRING_FILE)" \
-Psigning.password="$(NEXUS_GPG_PASSWORD)" \
-Psigning.keyId="$(NEXUS_GPG_KEY_ID)"
@echo "Now you go https://s01.oss.sonatype.org, close the temporarly created staging repository and release it"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was technically incorrect, we use "closeAndReleaseSonatypeStagingRepository" which afaik does that for us

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think this is a leftover

korniltsev
korniltsev approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Makefile
@@ -15,7 +15,6 @@ publish:
-Psigning.secretKeyRingFile="$(NEXUS_GPG_SECRING_FILE)" \
-Psigning.password="$(NEXUS_GPG_PASSWORD)" \
-Psigning.keyId="$(NEXUS_GPG_KEY_ID)"
@echo "Now you go https://s01.oss.sonatype.org, close the temporarly created staging repository and release it"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think this is a leftover

@aleks-p aleks-p merged commit 7adf33b into main Nov 28, 2024
38 checks passed
@aleks-p aleks-p deleted the chore/move-to-gh-actions branch November 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleks-p @korniltsev