Add disk caching in ingester SearchTagValuesV2 for completed blocks #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
force-pushed
the
meta_cache_ingester
branch
2 times, most recently
from
ef5996d to
dcf5b65
Compare
electron0zero
force-pushed
the
meta_cache_ingester
branch
from
dcf5b65 to
4d32d79
Compare
electron0zero
changed the title
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
electron0zero
changed the title
mdisibio
reviewed
Sep 19, 2024
mdisibio
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
cache the response for TagValuesV2 requests alongside the local blocks on the ingesters, this should speedup the autocomplete queries hitting ingesters.
In our dev env, it shows sizeable difference in p90, p95 of latency and throughout for tags that has values with high cardinality.
also updated instrumentation to make the ingester search spans more closer to the code.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]