Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten file permissions #4251

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Tighten file permissions #4251

merged 4 commits into from
Oct 31, 2024

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Oct 30, 2024

What this PR does:

Here we adjust adjust permissions of files and directories which are managed by the tempo process at runtime. Additionally, this changes the docker image permissions of /var/tempo to remove group and world access entirely (0700).

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you tested it with our docker-compose examples?

@zalegrala
Copy link
Contributor Author

I deployed an image to k8s, but I'll test docker compose before merging. Good call.

@zalegrala zalegrala merged commit 6607ab3 into grafana:main Oct 31, 2024
16 checks passed
@zalegrala zalegrala deleted the filePermissions branch October 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants