Docs: fix trace:rootService example code #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the example filter to match the actual intrinsic name.
|
|
seizethedave
requested review from
knylander-grafana,
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
knylander-grafana
approved these changes
Nov 4, 2024
|
This PR must be merged before a backport PR will be created. |
Improve the grammar of the def column for 2 fields.
|
This looks great. If you're good, I'll go ahead and merge. Thank you again! |
|
@knylander-grafana merge away! |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
* Docs: fix trace:rootService example code Update the example filter to match the actual intrinsic name. * PR feedback. Improve the grammar of the def column for 2 fields. (cherry picked from commit 07e41b7)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example filter to match the actual intrinsic name.
What this PR does:
This fixes a reference to
trace:rootServiceNamein the query intrinsics table. (trace:rootServiceNameproduces an error when you try to use it.)Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]