Migrate docker-ci-tools workflow to Github Actions #4454
+76
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| name: docker-ci-tools | ||
| on: | ||
| push: | ||
| branches: | ||
| - 'main' | ||
| paths: | ||
| - 'tools/**' | ||
|
|
||
| env: | ||
| IMAGE_NAME: grafana/tempo-ci-tools | ||
|
|
||
| # Needed to login to DockerHub | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
|
|
||
| jobs: | ||
|
|
||
| get-image-tag: | ||
| runs-on: ubuntu-24.04 | ||
| outputs: | ||
| tag: ${{ steps.get-tag.outputs.tag }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - id: get-tag | ||
| run: | | ||
| echo "tag=$(./tools/image-tag)" >> "$GITHUB_OUTPUT" | ||
| docker-ci-tools: | ||
| needs: get-image-tag | ||
| strategy: | ||
| matrix: | ||
| runner_arch: [ { runner: ubuntu-24.04, arch: amd64 }, { runner: github-hosted-ubuntu-arm64, arch: arm64 } ] | ||
| runs-on: ${{ matrix.runner_arch.runner }} | ||
| env: | ||
| TAG: ${{ needs.get-image-tag.outputs.tag }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Login to DockerHub | ||
| uses: grafana/shared-workflows/actions/[email protected] | ||
|
|
||
| - name: docker-build-and-push | ||
| run: | | ||
| TAG_ARCH="$TAG-${{ matrix.runner_arch.arch }}" | ||
| docker build -f tools/Dockerfile -t $IMAGE_NAME:$TAG_ARCH . | ||
| docker push $IMAGE_NAME:$TAG_ARCH | ||
| manifest: | ||
|
There was a problem hiding this comment. I think this is not needed since we are not pushing a multi-architecture image yet There was a problem hiding this comment. And it can be achieved as well with docker There was a problem hiding this comment. In Drone we do something very similar to what I'm doing here, that is, build each platform natively and then create a multi-platform manifest -- only that in Drone we use some opaque plugins. To clarify, this workflow is a combination of these Drone pipelines: |
||
| needs: ['get-image-tag', 'docker-ci-tools'] | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| TAG: ${{ needs.get-image-tag.outputs.tag }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Login to DockerHub | ||
| uses: grafana/shared-workflows/actions/[email protected] | ||
|
|
||
| - name: docker-manifest-create-and-push | ||
| run: | | ||
| docker manifest create \ | ||
| $IMAGE_NAME:$TAG \ | ||
| --amend $IMAGE_NAME:$TAG-amd64 \ | ||
| --amend $IMAGE_NAME:$TAG-arm64 | ||
| docker manifest push $IMAGE_NAME:$TAG | ||
| docker manifest create \ | ||
| $IMAGE_NAME:latest \ | ||
| --amend $IMAGE_NAME:$TAG-amd64 \ | ||
| --amend $IMAGE_NAME:$TAG-arm64 | ||
| docker manifest push $IMAGE_NAME:latest | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried this action?
docker/build-push-action@v6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had seen that but I prefer to do it this way because it is more explicit and we can build each platform natively, while the other action relies on QEMU which is probably slower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to it but other teams are using it:
https://github.com/grafana/loki/blob/e6d82b9253a46a08120dccf4317fd1d25c1d4ca3/.github/workflows/images.yml#L48
I think it simplifies the process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say we review this once we have migrated everything, I'm sure there's room for optimization in our CI but I don't want to change things too much during the migration to make sure I don't break any process.