Nomad job example #4469
Nomad job example #4469
Conversation
bcirh
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
|
|
There was a problem hiding this comment.
A few questions. I have no nomad experience, but I'm fine with this PR. The danger is that this becomes out of date and no one on the team knows how to maintain it.
I think it's fine. If the nomad loving community keeps this up to date then we will keep it. If in a year it's had no updates and it no longer works we will likely remove it.
| resources { | ||
| cpu = 200 | ||
| memory = 128 | ||
| memory_max = 2048 |
There was a problem hiding this comment.
do we want to specify a max? I guess as an example that's fine, but resource usage of Tempo can cover a huge range depending on usage patterns.
There was a problem hiding this comment.
memory value is how much RAM will nomad reserve for the task, memory_max value is how much task can expand if it goes above reserved memory (memory oversubscription). memory_max values can be removed, in that case value of memory will be max value. I would leave it as is, since this is an example, pepole can decide what works best for them. I will update README.md to address this.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]