Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Panel Datasource: Use OpenAPI client #1160

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Nov 14, 2023

Use https://github.com/grafana/grafana-openapi-client-go instead of the manually generated client

grafana/grafana-openapi-client-go#31 needs to be merged first!

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne force-pushed the julienduchesne/ds-library-openapi branch 2 times, most recently from 5551775 to 00ac181 Compare November 15, 2023 17:14
@julienduchesne julienduchesne force-pushed the julienduchesne/ds-library-openapi branch from 00ac181 to abd4f0b Compare November 15, 2023 17:18
@julienduchesne julienduchesne marked this pull request as ready for review November 15, 2023 17:24
@julienduchesne julienduchesne requested a review from a team as a code owner November 15, 2023 17:24
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienduchesne julienduchesne merged commit 39857cb into master Nov 21, 2023
@julienduchesne julienduchesne deleted the julienduchesne/ds-library-openapi branch November 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants