Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create initial deploy preview comment after build completes #907

Merged
merged 12 commits into from
Nov 28, 2024

Conversation

robbymilo
Copy link
Contributor

@robbymilo robbymilo commented Nov 28, 2024

for https://github.com/grafana/website/issues/10101

This should fix the comment issue seen in grafana/grafana#97140.

Before merge:

  • revert ref change

@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
@grafana grafana deleted a comment from github-actions bot Nov 28, 2024
Copy link
Contributor

@robbymilo robbymilo marked this pull request as ready for review November 28, 2024 09:39
@robbymilo robbymilo requested a review from a team as a code owner November 28, 2024 09:39
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh should have checked the logic precedence more carefully. This patch makes more sense and makes it easier to understand for the future too.

@robbymilo robbymilo merged commit 74d0631 into main Nov 28, 2024
5 checks passed
@robbymilo robbymilo deleted the robbymilo/deploy-preview branch November 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants