Merge 4.2.x into 5.0.x #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces explicit delegation to improve convenience and support for IDE autocompletion. The following delegates have been added: - `browser` object delegate - `page` object delegate - `report(String)` method delegate - `getPageSource()` method delegate - Refactor `ContainerAwareDownloadSupport` to a more generic support trait and move `createFileInputSource` method to it. - Move support classes to `support` package.
- This enables IDE autocompletion to display correct parameter names, improving developer experience.
Geb classes lack parameter metadata, which prevents proper IDE autocompletion. To address this, we manually delegate to enable accurate parameter names. - Add delegate implementations for all Geb interfaces in `ContainerGebSpec`. - Move container-related logic to the `ContainerSupport` class for better separation of concerns. - Add `@CompileStatic` where possible.
The `@since` attribute in the `ContainerSupport` class was incorrectly set to `4.1`. Updated it to the correct version, `4.2`.
Enhance Developer Experience with Explicit Delegation
- Upgrade `gradle-versions-plugin` to the latest release. - See the [release notes](https://github.com/ben-manes/gradle-versions-plugin/releases/tag/v0.52.0) for details.
… to 3.26.3 - Upgrade `javaparser-core` to the latest patch release. - See the [release notes](https://github.com/javaparser/javaparser/releases/tag/javaparser-parent-3.26.3) for details.
- Upgrade `selenium` to the latest release. - See the [changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/java/CHANGELOG) for details.
- Leverage `ContainerGebSpec.pageSource` delegate for improved readability. - Use an instance of the page object for better type hints.
- Align test project with the main project's Gradle version.
- [3.19.1 Release Notes](https://plugins.gradle.org/plugin/com.gradle.develocity/3.19.1) - [3.19 Release Notes](https://plugins.gradle.org/plugin/com.gradle.develocity/3.19)
- Migrate from `GRADLE_ENTERPRISE_ACCESS_KEY` to `DEVELOCITY_ACCESS_KEY`. - Use `--continue` on build and test tasks to report all errors. - Use `--no-build-cache` on publish to prevent caching issues. - Remove `SECRING_FILE` environment variable from `publishToSonatype` as it's not needed. - Update cog emoji in step name.
Miscellaneous cleanup and maintenance tasks
# Conflicts: # .github/workflows/gradle.yml # .github/workflows/release.yml # build.gradle # gradle.properties # spock-container-test-app/gradle/wrapper/gradle-wrapper.jar # spock-container-test-app/gradle/wrapper/gradle-wrapper.properties # spock-container-test-app/gradlew # spock-container-test-app/gradlew.bat # src/testFixtures/groovy/grails/plugin/geb/ContainerAwareDownloadSupport.groovy # src/testFixtures/groovy/grails/plugin/geb/ContainerGebSpec.groovy
|
Needs grails/grails-gradle-plugin#396 for successful snapshot publishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.