Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "node" condition to "." entry point #438

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

wojpawlik
Copy link
Contributor

@wojpawlik wojpawlik commented Jun 18, 2023

Towards #372

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b5cb51) 38.67% compared to head (08cd266) 38.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   38.67%   38.67%           
=======================================
  Files          16       16           
  Lines        4815     4815           
  Branches      194      194           
=======================================
  Hits         1862     1862           
  Misses       2951     2951           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnorpelSenf KnorpelSenf requested a review from roziscoding June 18, 2023 20:35
@KnorpelSenf
Copy link
Member

@roziscoding could you run the tests again which you performed for #339?

@roziscoding
Copy link
Contributor

@roziscoding could you run the tests again which you performed for #339?

In a few hours probably :)

@roziscoding
Copy link
Contributor

It works with Vite + Vue, and with node with both JS and TS

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KnorpelSenf KnorpelSenf merged commit 5db9308 into main Jun 19, 2023
@KnorpelSenf KnorpelSenf deleted the wojpawlik-patch-1 branch June 19, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants