Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: fix Azure Function v4 Adapter HttpRequest and InvocationContext Type #742

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mildronize
Copy link

As mentioned in #737 (comment)

@mildronize mildronize changed the title type: fix Azure Function v4 Adapter HttpRequest and Context Type type: fix Azure Function v4 Adapter HttpRequest and InvocationContext Type Jan 16, 2025
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to copy all properties of the type definition to grammY, most of them are not needed. Can you reduce the type definitions to only what's needed here?

src/convenience/frameworks.ts Outdated Show resolved Hide resolved
src/convenience/frameworks.ts Outdated Show resolved Hide resolved
@mildronize
Copy link
Author

@KnorpelSenf Is it look good now?

@KnorpelSenf
Copy link
Member

I think this actually won't compile, but let's fix the last few things in #738

@KnorpelSenf KnorpelSenf merged commit 2f6de5a into grammyjs:support-azure-v4 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants