Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands plugin page #1018

Merged
merged 92 commits into from
Nov 17, 2024
Merged

Add commands plugin page #1018

merged 92 commits into from
Nov 17, 2024

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented Mar 21, 2024 •
edited by roziscoding
Loading

First draft of the docs for the Commands plugin

@roziscoding roziscoding marked this pull request as ready for review April 27, 2024 20:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited
Loading

🚀 Deployed on https://67367e234a9e108eec61d020--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 27, 2024 20:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 27, 2024 20:32 Inactive
quadratz
quadratz requested changes Apr 28, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
quadratz
quadratz requested changes Apr 28, 2024
View reviewed changes
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
site/docs/plugins/commands.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 28, 2024 03:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 29, 2024 19:32 Inactive
@carafelix
- restructure read flow to focus first on a full working example
c5b62b8 
- add examples on command scoping
- add examples on command grouping
- add regExp section
- add reference to telegram docs on commands
- add mention to languageCode obj utility
- typos
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 04:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 04:12 Inactive
@carafelix
- add note on upperCased command names
fb7ee75 
- remove wrong code on localization example
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 18:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 16:48 Inactive
@carafelix carafelix requested a review from quadratz June 20, 2024 16:52
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 16:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 16:45 Inactive
@MasedMSD
Copy link
Collaborator

I'm completely confused with these changes. I'm unsync the Russian version soon!

@KnorpelSenf
Copy link
Member Author

KnorpelSenf commented Nov 13, 2024 •
edited
Loading

Yep, sorry about that. It should never happen that any translator has to sync things. This was just a mistake.

Usually, it always works like this:

  1. we perform changes to English (you can ignore them)
  2. we add a label “ready for translation”
  3. you translate things (we are not going to touch English again)
  4. we merge

If more changes to English are necessary after we add the label in step 2, they will be done in a subsequent PQ. As a result, once you are done translating, you can completely forget about a PQ and ignore all changes. This will make it almost impossible for the languages to get out of sync.

@carafelix just did not know this and changed some docs even after “ready for translation” was added, which caused confusion.

@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 18:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 18:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 06:37 Inactive
@carafelix
Copy link
Member

carafelix commented Nov 14, 2024 •
edited
Loading

The Chinese translation is throwing the following error in the link check task

Missing anchors (1)
Some links were pinned with an anchor. But the linked document doesn't have such an anchor.

 #前缀
    at /home/runner/work/website/website/site/docs/zh/plugins/commands.md:540:25

@KnorpelSenf
Copy link
Member Author

I see it, too. It doesn't when being run locally. I'll retry CI

@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 21:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 22:48 Inactive
@KnorpelSenf
Copy link
Member Author

Fixed

@KnorpelSenf
Copy link
Member Author

Omg this is the 200th comment on this PQ, crazy

@KnorpelSenf
Copy link
Member Author

lessgo

@KnorpelSenf KnorpelSenf added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit cb924cc Nov 17, 2024
6 checks passed
@KnorpelSenf KnorpelSenf deleted the commands-plugin branch November 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roziscoding roziscoding roziscoding approved these changes

@tsvetkovv tsvetkovv tsvetkovv left review comments

@carafelix carafelix carafelix left review comments

@MasedMSD MasedMSD MasedMSD left review comments

@quadratz quadratz quadratz left review comments

@niusia-ua niusia-ua niusia-ua left review comments

@deptyped deptyped deptyped approved these changes

@habemuscode habemuscode habemuscode approved these changes

@rojvv rojvv rojvv approved these changes

@LWJerri LWJerri LWJerri approved these changes

Assignees
No one assigned
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇷🇺 RU Modifies or is related to the Russian translations. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.