Add type hints to latitude and longitude methods and functions #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenyoungs
force-pushed
the
typing-withinarea
branch
from
5dc8751 to
8701f17
Compare
stevenyoungs
changed the title
QuLogic
reviewed
Jan 31, 2025
stevenyoungs
force-pushed
the
typing-withinarea
branch
from
1078b45 to
8cc4629
Compare
cdhorn
reviewed
Feb 2, 2025
Adds types hints to lat and lon and methods called to initialise latit and longit. Co-authored-by: Christopher Horn <[email protected]>
Nick-Hall
force-pushed
the
typing-withinarea
branch
from
6af9532 to
a9a5e3c
Compare
|
Rebased and squashed commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PR I commented on a change to this line
if lat and lon:in the file
gramps/gen/filters/rules/place/_withinarea.pyThis PR adds types hints to
latandlonand methods called to initialiselatitandlongit