Fix reversed byte order in custom file protocol #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the packed integer was being turned into a reversed byte array. This isn't really an issue as long as it's converted back into a packed integer using the same logic. `settings.web-directory.read-only` will need to be set to `false` in the config when updating Pl3xMap to the version with this fix, since it includes changes to the webmap files.
granny
force-pushed
the
fix/custom-file-reversed-byte-order
branch
from
d96ca17 to
54bfa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the packed integer was being turned into a reversed byte array. This isn't really an issue as long as it's converted back into a packed integer using the same logic.
settings.web-directory.read-onlywill need to be set tofalsein the config when updating Pl3xMap to the version with this fix, since it includes changes to the webmap files.Will be merged when updating to the next future minecraft update.