Dockerize me and set me up for wider adoption #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphaelli
requested changes
Oct 4, 2022
Comment on lines
+6
to
+21
|
|
||
| ## Pre-requisites | ||
|
|
||
| We'll be using the Terminal app to run commands. | ||
| You can already launch it by hitting the `command+space` keys then searching for `terminal`. | ||
|
|
||
| ### Install Docker and configure it | ||
|
|
||
| 1. Download and install [Docker Desktop](https://docs.docker.com/desktop/install/mac-install/) for Mac. | ||
| You'll get a warning saying that Docker Desktop needs privileged access - you will need to enter your computer password when prompted. | ||
| You'll see a "Docker Subscription Service Agreement" screen - accept it. | ||
|
|
||
| 2. Start Docker and create an account | ||
| Open the Docker app, and follow the steps to create an account. | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| ## Pre-requisites | |
| We'll be using the Terminal app to run commands. | |
| You can already launch it by hitting the `command+space` keys then searching for `terminal`. | |
| ### Install Docker and configure it | |
| 1. Download and install [Docker Desktop](https://docs.docker.com/desktop/install/mac-install/) for Mac. | |
| You'll get a warning saying that Docker Desktop needs privileged access - you will need to enter your computer password when prompted. | |
| You'll see a "Docker Subscription Service Agreement" screen - accept it. | |
| 2. Start Docker and create an account | |
| Open the Docker app, and follow the steps to create an account. |
This is not zat specific so I'd prefer we just remove it altogether
Comment on lines
+22
to
+33
| ### Log into Elastic container registry | ||
|
|
||
| We're now going to log into Elastic container registry, where we'll download zat. | ||
| Visit [https://docker-auth.elastic.co](https://docker-auth.elastic.co) - click on the `Login to @elastic with GitHub` button. | ||
| You may get redirect to an Okta log-in screen, but eventually will see a page as below: | ||
|
|
||
|  | ||
|
|
||
|
|
||
| Copy the full line, after the `$` sign and paste it into the Terminal window and press enter. | ||
| You should see a `Login Succeeded` message. | ||
|
|
There was a problem hiding this comment.
Suggested change
| ### Log into Elastic container registry | |
| We're now going to log into Elastic container registry, where we'll download zat. | |
| Visit [https://docker-auth.elastic.co](https://docker-auth.elastic.co) - click on the `Login to @elastic with GitHub` button. | |
| You may get redirect to an Okta log-in screen, but eventually will see a page as below: | |
|  | |
| Copy the full line, after the `$` sign and paste it into the Terminal window and press enter. | |
| You should see a `Login Succeeded` message. |
This is a high barrier too, why not just docker hub since this is all public anyway?
| 4. Verify that it loaded correctly | ||
| ``` | ||
| tail /tmp/zat.log | ||
| ``` |
There was a problem hiding this comment.
Lots of overlap here with the README but these are excellent and I love the screenshots - I'd be happy to merge this in and consolidate the two docs in a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dockerized version of Zat, and a detailed installation guide for folks who may not have a full dev. environment setup.
Notes:
/usr/local/etc/zat/was really appealing, DockerDesktop, at least on mac, does not allow that location by default - so I picked $HOME/.zatconfig instead