Make PaletteChangeNotifier a QQuickItem, reducing quantity of palette…

…Changed signal emissions
graphia-app · Oct 21, 2023 · 6516836 · 6516836
1 parent e1083e8
commit 6516836
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/source/shared/utils/palettechangenotifier.cpp b/source/shared/utils/palettechangenotifier.cpp
@@ -23,17 +23,18 @@
 #include <QApplication>
 #include <QQmlEngine>
 
-PaletteChangeNotifier::PaletteChangeNotifier(QObject* parent) : QObject(parent)
-{
-    QCoreApplication::instance()->installEventFilter(this);
-}
+PaletteChangeNotifier::PaletteChangeNotifier(QQuickItem* parent) : QQuickItem(parent)
+{}
 
-bool PaletteChangeNotifier::eventFilter(QObject* watched, QEvent* event)
+bool PaletteChangeNotifier::event(QEvent* event)
 {
     if(event->type() == QEvent::ApplicationPaletteChange)
+    {
         emit paletteChanged();
+        return true;
+    }
 
-    return QObject::eventFilter(watched, event);
+    return QObject::event(event);
 }
 
 static_block

diff --git a/source/shared/utils/palettechangenotifier.h b/source/shared/utils/palettechangenotifier.h
@@ -19,21 +19,21 @@
 #ifndef PALETTECHANGENOTIFIER_H
 #define PALETTECHANGENOTIFIER_H
 
-#include <QObject>
+#include <QQuickItem>
 #include <QEvent>
 
-class PaletteChangeNotifier : public QObject
+class PaletteChangeNotifier : public QQuickItem
 {
     Q_OBJECT
 
 public:
-    explicit PaletteChangeNotifier(QObject* parent = nullptr);
+    explicit PaletteChangeNotifier(QQuickItem* parent = nullptr);
 
 signals:
     void paletteChanged();
 
 protected:
-    bool eventFilter(QObject* watched, QEvent* event) override;
+    bool event(QEvent* event) override;
 };
 
 #endif // PALETTECHANGENOTIFIER_H