Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update to contribution notes #888

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Small update to contribution notes #888

wants to merge 3 commits into from

Conversation

idalithb
Copy link
Contributor

  • copy edits
  • @benface it automatically included changelog updates, should I expect this moving forward?

@idalithb idalithb requested a review from a team as a code owner February 26, 2025 19:18
@idalithb idalithb changed the title Small updated to contribution notes Small update to contribution notes Feb 26, 2025
@benface
Copy link
Contributor

benface commented Feb 27, 2025

it automatically included changelog updates, should I expect this moving forward?

Ah yes @idalithb, that's the fetch-remote-docs script doing that; it runs automatically before the build (EDIT: and before pnpm run dev 😱 which I didn't realize, but not anymore). You can always decide to not include those changes in your commits (feel free to discard them completely); it's a similar situation to what I explained here. Those remote content updates will still make their way to production because they will be fetched before CI/CD builds and deploy the docs, regardless of whether they are in git. I would say no big deal to include them either.

Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads so much better! Thank you! 🙌

idalithb and others added 2 commits February 27, 2025 15:02
Co-authored-by: Benoît Rouleau <[email protected]>
Co-authored-by: Benoît Rouleau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants