Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@graphql-hive/importer and point to exact syntax error while parsing config #462

Merged
merged 40 commits into from
Jan 17, 2025
Merged

@graphql-hive/importer and point to exact syntax error while parsing config #462

merged 40 commits into from
Jan 17, 2025

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Jan 15, 2025 •
edited
Loading

Closes ardatan/graphql-mesh#8267

@graphql-hive/importer is pretty much a slimmed down and improved version of @graphql-hive/include

  • No jiti
  • Zero-dependency bundle
  • Filepaths in syntax errors
  • Type-safer
  • Tested transpiler

Other improvements

  • Processes that have exitted before test end wont exit again in the leftover stack
  • Docker container will be added to the leftover stack only if the container was actually started
  • No more leftover child processes after E2Es complete

TODO

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-graphql-ws 1.3.8-alpha-244af41752af32f24982dabbf66153f3c2b17637 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.8.0-alpha-244af41752af32f24982dabbf66153f3c2b17637 npm ↗︎ unpkg ↗︎
@graphql-hive/importer 1.0.0-alpha-244af41752af32f24982dabbf66153f3c2b17637 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-ws 0.4.17-alpha-244af41752af32f24982dabbf66153f3c2b17637 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.8.0-alpha-244af41752af32f24982dabbf66153f3c2b17637

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.8.0-alpha-244af41752af32f24982dabbf66153f3c2b17637-bun

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@enisdenjo enisdenjo mentioned this pull request Jan 15, 2025
Closed
4 tasks
@enisdenjo enisdenjo marked this pull request as draft January 15, 2025 18:54
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 15, 2025 •
edited
Loading

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

enisdenjo
enisdenjo commented Jan 16, 2025
View reviewed changes
internal/e2e/src/tenv.ts
@@ -526,7 +526,6 @@ export function createTenv(cwd: string): Tenv {
path.resolve(__project, 'packages', 'gateway', 'src', 'bin.ts'),
...getFullArgs(),
);
leftoverStack.use(proc);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because the same process was added twice to the stack.

@enisdenjo enisdenjo requested a review from ardatan January 16, 2025 13:53
@enisdenjo enisdenjo marked this pull request as ready for review January 16, 2025 13:54
@enisdenjo enisdenjo requested a review from dotansimha January 16, 2025 13:54
@enisdenjo enisdenjo force-pushed the config-syntax-error branch from 301581d to 79c68a0 Compare January 16, 2025 15:31
@enisdenjo enisdenjo merged commit 9a6ae85 into main Jan 17, 2025
56 checks passed
@enisdenjo enisdenjo deleted the config-syntax-error branch January 17, 2025 17:04
@theguild-bot theguild-bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardatan ardatan ardatan approved these changes

@dotansimha dotansimha Awaiting requested review from dotansimha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cryptic runtime error when running hive-gateway supergraph
3 participants
@enisdenjo @theguild-bot @ardatan