fix: capture error correctly in withConn

gravitational · Nov 8, 2022 · d5ec4a6 · d5ec4a6
1 parent ed9116f
commit d5ec4a6
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/redis.go b/redis.go
@@ -290,11 +290,9 @@ func (c *baseClient) withConn(
 		return err
 	}
 
-	defer func() {
-		c.releaseConn(ctx, cn, err)
-	}()
-
-	return fn(ctx, cn)
+	err = fn(ctx, cn)
+	c.releaseConn(ctx, cn, err)
+	return err
 }
 
 func (c *baseClient) dial(ctx context.Context, network, addr string) (net.Conn, error) {