Add more lint coverage #10049
Merged
Add more lint coverage #10049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcsc
reviewed
Feb 1, 2022
| @@ -102,8 +102,8 @@ ENV GOPATH="/go" \ | |||
| RUN go install github.com/google/[email protected] | |||
|
|
|||
| # Install meta-linter. | |||
| RUN (curl -L https://github.com/golangci/golangci-lint/releases/download/v1.38.0/golangci-lint-1.38.0-$(go env GOOS)-$(go env GOARCH).tar.gz | tar -xz && \ | |||
| cp golangci-lint-1.38.0-$(go env GOOS)-$(go env GOARCH)/golangci-lint /bin/ && \ | |||
| RUN (curl -L https://github.com/golangci/golangci-lint/releases/download/v1.44.0/golangci-lint-1.44.0-$(go env GOOS)-$(go env GOARCH).tar.gz | tar -xz && \ | |||
There was a problem hiding this comment.
We will have to re-spin the buildbox, or update the linter script, in order for this update to make it onto CI.
There was a problem hiding this comment.
Yeah I figured there would be more involved than this. But I was constantly getting errors that aren't picked up by CI and believe it is due to the older version.
There was a problem hiding this comment.
I have PR #10179 that will remove some of the manual buildbox image management for GCB
There was a problem hiding this comment.
nit: I think the comment here is out of date. If I had to guess, at some point we switched from go-metalinter to golangci-lint and left the old install comment.
rosstimothy
force-pushed
the
tross/better_coverage
branch
from
e77024b to
c0d4c9f
Compare
rosstimothy
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
tcsc
approved these changes
Feb 7, 2022
zmb3
approved these changes
Feb 7, 2022
golanglint-ci doesn't pick up subdirectories with their own go.mod which left certain directories unlinted. To get around this we can run golanglint-ci directly against those submodules.
rosstimothy
force-pushed
the
tross/better_coverage
branch
from
6cd6379 to
4ece427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lintdoesn't lint any subdirectories with their owngo.mod(golangci/golangci-lint#828) which left a few directories unlinted. To get around this we canrun
golangci-lintdirectly against those submodules.This also provides fixes for new lint errors detected by running
golangci-lintin these directories.