feat(Notifications): static component implementation (DATAUI-1582)

[Ruminat]

That's how it looks

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.

[gravity-ui-bot]

Preview is ready.

[Ruminat]

@amje @ValeraS @korvin89
Посмотрите PR?

[korvin89]

Lets add this component into /Notifications

[Ruminat]

Do you mean moving the index.ts's content into Notifications/index.ts or moving the whole Notification directory's content into Notifications directory?

[korvin89]

Whole directory. I think /components should have only exported elements. Notification seems like part of Notifications

[Ruminat]

/Notification can be exported alone, if, for example, you already have some container that you want to use for your notifications that is different from what /Notifications offers you
Another point is that /Notification has it's own Notification.scss. So if put together, the styles are going to be in one big file and become harder to read
Or is it a common practice in your repository to put different style files in one directory? If so, I don't see a problem putting them in a single directory

[korvin89]

1. U should rename PR to have properly working CI
2. Will u add some tests?

[Ruminat]

@korvin89

U should rename PR to have properly working CI

• renamed

Will u add some tests?

• I couldn't find any tests in your repository, can you provide me with some references? And I can't really think of any tests yet — it's a component with basically no logic except for the swiping.

[korvin89]

I couldn't find any tests in your repository, can you provide me with some references? And I can't really think of any tests yet — it's a component with basically no logic except for the swiping.

Yep, we do not have tests yet. And it is not good. U can add an issue for tests and do it later. I am talking about testing of basic functionality, for example here. There is a good reference for jest configuration here.

[Ruminat]

Yep, we do not have tests yet. And it is not good. U can add an issue for tests and do it later. I am talking about testing of basic functionality, for example here. There is a good reference for jest configuration here.

Created an issue — #62

[Ruminat]

After consulting our designer, I rewrote the NotificationWithSwipe component.
It now uses the tinygesture library instead of the swipejs.
I also made a small NotificationSwipeAction component for simplification of writing swipe actions.