Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): create components overview page #3324

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3329

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint
Copy link
Member Author

xelaint commented Oct 29, 2024

@griest024 can you help me link up the cards to the doc list data?

@griest024 griest024 marked this pull request as ready for review November 1, 2024 22:20
@griest024 griest024 requested review from a team as code owners November 1, 2024 22:20
@griest024
Copy link
Member

@xelaint done

@xelaint
Copy link
Member Author

xelaint commented Nov 2, 2024

@griest024 form is using the error message component's description, and all the components under form are not shown in the cards. Would this be fixed if we move these components to their own subpackages?

Screen Shot 2024-11-02 at 9 51 04 AM Screen Shot 2024-11-02 at 9 50 50 AM

@griest024
Copy link
Member

@xelaint oh yeah it would. I can also do some hard coding to fix it in the short term

@xelaint
Copy link
Member Author

xelaint commented Nov 4, 2024

@xelaint oh yeah it would. I can also do some hard coding to fix it in the short term

hardcoding might be better for now? since all of these components need to be redone.

@griest024
Copy link
Member

@xelaint done

@xelaint xelaint merged commit bbd2fa1 into develop Nov 25, 2024
8 checks passed
@damienwebdev damienwebdev deleted the components-overview-page branch November 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Daffio design components overview 404
2 participants